dts: arm: nordic: nrf5340: Add missing ranges property for QSPI #97704
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
bjarki-andreasen,
jaz1-nordic,
kl-cruz,
lstnl,
magp-nordic,
masz-nordic and
nika-nordic
bjarki-andreasen
previously approved these changes
Oct 16, 2025
kylebonnici
suggested changes
Oct 16, 2025
kylebonnici
reviewed
Oct 16, 2025
dts/arm/nordic/nrf5340_cpuapp.dtsi
Outdated
| #size-cells = <1>; | ||
| ranges = <0x0 0x50000000 0x10000000>; | ||
| ranges = <0x0 0x50000000 0x10000000>, | ||
| <0x1 0x10000000 0x10000000>; |
There was a problem hiding this comment.
why 0x01 and not 0x10000000?
This was missing the XIP region Signed-off-by: Jamie McCrae <[email protected]>
|
kylebonnici
approved these changes
Oct 16, 2025
bjarki-andreasen
approved these changes
Oct 17, 2025
anangl
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing the XIP region